Fix the tests #67
Merged
Fix the tests #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
fix-tests
branch
2 times, most recently
from
8e86687 to
f493026
Compare
Also adds acceptance tests for Debian 9 and simplifications in the params.
ekohl
commented
Nov 9, 2017
| $daemon_group = 'proxy' | ||
| } | ||
| /^(9.*)$/: { | ||
| $package_name = 'squid3' |
There was a problem hiding this comment.
According to https://packages.debian.org/stretch/squid3 this is a transitional package that depends on squid. That makes it exactly the same as Ubuntu 16.04.
| $config_group = 'root' | ||
| $access_log = 'daemon:/var/log/squid/access.log squid' | ||
| $daemon_user = 'proxy' | ||
| $daemon_group = 'proxy' | ||
| } | ||
| default: { |
There was a problem hiding this comment.
According to metadata.json we only supported explicitly written out versions. I've taken the most modern versions (Stretch and Xenial) and made them the default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some simplifications in the params.