When specifying the extra_config_sections as an array #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbosz
force-pushed
the
extra_config_section
branch
5 times, most recently
from
15f397c to
4d38dc3
Compare
|
We can't just change the test here in the .robocop.yml , the file is templated in. |
ralfbosz
force-pushed
the
extra_config_section
branch
from
4d38dc3 to
637e417
Compare
|
I've reversed the .rubocop.yml to the "master-branch" version, but still shows as diff in the PR. The change was made to make it pass the Travis CI, don't have everything installed on my current machine to do local testing... Ok removed the .rubcopy.yml from the commit... |
|
it failed at first, seems the docker-image of ubuntu-16.04 requires the installation of "locales", since "locale-gen en_US.UTF-8" is not available otherwise. fixed it in the PR, now it's all green... |
ralfbosz
force-pushed
the
extra_config_section
branch
2 times, most recently
from
8fd7fc8 to
47025ef
Compare
traylenator
approved these changes
Jun 30, 2017
.rubocop.yml
Outdated
| @@ -302,7 +302,7 @@ Style/EmptyLiteral: | |||
| Metrics/LineLength: | |||
| Enabled: False | |||
|
|
|||
| Style/MethodCallParentheses: | |||
| Style/MethodCallWithoutArgsParentheses: | |||
There was a problem hiding this comment.
Can this be submitted to pass with out modifying the rubocop configuration?
traylenator
added
needs-rebase
enhancement
The option "extra_config_section" can be defined as an array, this adds the option to create multiple lines instead of one big line with all the parameters. This commit addresses issue voxpupuli#31
ralfbosz
force-pushed
the
extra_config_section
branch
from
47025ef to
ba3fe12
Compare
|
I've updated my PR, only changed what was needed for this function... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the entries are set on multiple lines instead of joined on the same line
also fixed an error in the example which was missing some }