Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate squid config before applying changes #123

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Validate squid config before applying changes #123

merged 1 commit into from
Apr 29, 2019

Conversation

alexjfisher
Copy link
Member

Rebase of #122 with also one minor edit. Stdlib::Absolutepath instead of String for data type of squid_bin_path.

@alexjfisher alexjfisher added the enhancement New feature or request label Apr 29, 2019
ekohl
ekohl approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to drop jessie/trusty in a separate PR

@alexjfisher alexjfisher merged commit 22c9d5f into voxpupuli:master Apr 29, 2019
@alexjfisher
Copy link
Member Author

Thanks @jocelynthode!

@alexjfisher alexjfisher mentioned this pull request Apr 29, 2019
Closed
@alexjfisher alexjfisher deleted the add_validate_config_rebase branch April 29, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexjfisher @ekohl