Bug fixes, lint, rubocop, spec tests etc. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update variables to match parameters. Not just a lint error, an actual bug! Signed-off-by: Alexander Fisher <[email protected]>
`::include splunk::platform::solaris` had the `::`s in the wrong place. Signed-off-by: Alexander Fisher <[email protected]>
These were just lint errors as opposed to actual bugs. Signed-off-by: Alexander Fisher <[email protected]>
* Add `fixtures.yml`.
* Add `default_module_facts.yml` with `staging_http_get` fact.
* Rubocop fixes in `spec/classes/example_spec.rb`.
* Remove completely broken tests.
Looks like there aren't really any tests and
`spec/classes/example_spec.rb` is just boilerplate/skeleton.
For instance there is no `config.pp` manifest, so
```ruby
it { is_expected.to contain_class('splunk::config') }
```
was never going to pass!
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
For consistency with other Vox Pupuli maintained modules. Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
Signed-off-by: Alexander Fisher <[email protected]>
alexjfisher
changed the title
alexjfisher
commented
Sep 26, 2016
| @@ -13,7 +13,7 @@ def self.file_path | |||
| File.join(@file_path, file_name) | |||
| end | |||
|
|
|||
| def self.set_file_path(path) | |||
| def self.set_file_path(path) # rubocop:disable Style/AccessorMethodName | |||
There was a problem hiding this comment.
I wimped out here. Somebody with more knowledge of the module and how the inifile providers work could have a go if they really wanted to. Probably not worth it though.
There was a problem hiding this comment.
According to the rubocop docs we should rename this to
def self.file_path=(path)And then change the references to this method in splunk_config
eg;
Puppet::Type.type(res_type).provider(:ini_setting).file_path=(self[:server_confdir])
There was a problem hiding this comment.
def self.file_path=(path)
leads to Style/TrivialAccessors: Use attr_writer to define trivial writer methods. which can be fixed by replacing the whole thing with
attr_writer :file_pathI think?
Puppet::Type.type(res_type).provider(:ini_setting).file_path=(self[:server_confdir])leads to
Style/SpaceAroundOperators: Surrounding space missing for operator =at which point it was late and I got scared.
There was a problem hiding this comment.
I think you'll need....
class << self
attr_writer :file_path
end
|
@crayfishx Would you like to review this one? |
Changed set_file_path to be a simple attr_writer.
juniorsysadmin
approved these changes
Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of bug fixes. Lots of lint fixes. Tests (hardly any) now at least run. See individual commits for details.