Various updates and fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ziaunys
commented
Mar 17, 2016
Ziaunys
commented
- Adds the ability to run Splunk as a non-root user on posix systems.
- Adds the splunkforwarder_web type and provider from Nick Perry's fork.
- Adds purging for all the new Splunk types.
- Provisions all the config files to ensure they exist beforehand.
- Properly tags virtual resources.
- Corrects some permission issues.
- Depends on Update the resource ordering for the new Splunk types. #37 and this will need a rebase once its merged.
|
@Ziaunys how come you needed to abstract the ini_setting into a custom type/provider? It seems like an unnecessary abstraction, especially since the platform specific path for |
|
@bmjen I went and updated the splunkforwarder_web type to use the splunk_config meta resource. I'll eventually update more types to use this resource. |
- Adds the ability to run Splunk as a non-root user on posix systems. - Adds the splunkforwarder_web type and provider from Nick Perry's fork. - Modify the splunkforwarder_web type to use the splunk_config meta type in order to set the path from Puppet. - Adds purging for all the new Splunk types. - Provisions all the config files to ensure they exist beforehand. - Properly tags virtual resources. - Corrects some permission issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.