Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to manage net-tools package #303

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

mcmartins
Copy link

I believe this is a controversial pull request.

net-tools is very common dependency, and in a huge code base with many dependencies most likely it will be already declared somewhere.

I've introduced a flag manage_net_tools in params.pp with a default true, which will keep working as it is for everyone, but will allow projects like ours to mark it as false when net-tools is already managed somewhere else.

Thanks.

Manuel

@kenyon
Copy link
Member

kenyon commented Nov 25, 2020

Why does Splunk even need a package that's been obsolete/deprecated for like 20 years? 😞

@mcmartins
Copy link
Author

mcmartins commented Nov 25, 2020

My bad, I'll include some tests tomorrow. I'll update the documentation as well with a description for this flag.

@mcmartins
Copy link
Author

Added some tests on enterprise_spec.rb and updated the REFERENCE.md

@bastelfreak bastelfreak added the enhancement New feature or request label Dec 3, 2020
@bastelfreak
Copy link
Member

thanks for the PR. I rebased it against our latest master to pull in the updated CI matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants