Support ppc64le #290
Merged
Support ppc64le #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Could you please add a test of some sort. |
|
The facts in tests come from rspec-puppet-facts and facterdb and there is no existing tests that stress or check the actual package getting installed if installing from something like RPM. I could mock architecture fact but would require some more invasive changes to existing testing to test the full URL for the package and may make the tests very fragile as the thing I changed would change the very long package download URL that uses many facts and changes based on values in params class. |
|
Tests are still failing, not sure if this project was already broken. |
|
Looking at travis looks like the most recent pull requests tests from 2 weeks ago also failed on the same test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add support for ppc64le architecture which is supported for the universal forwarder. I wasn't sure if I should add logic to enterprise class to disallow ppc64le.