Add support for OpenSUSE #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added
enhancement
|
@martijndegouw thanks again for the PR. Please also take a look at the failing tests and add OpenSUSE to the metadata.json |
|
I looked into the failing tests, but it looks like the problem is in the test environment/existing code/puppet, not in the newly added code: Looks like ${facts['os']['architecture']} is not set correctly in the correspondig ruby/puppet version |
martijndegouw
force-pushed
the
OpenSUSE
branch
2 times, most recently
from
1a51616 to
f19f78b
Compare
|
Dear @martijndegouw, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
martijndegouw
force-pushed
the
OpenSUSE
branch
4 times, most recently
from
899ae50 to
02060ec
Compare
martijndegouw
force-pushed
the
OpenSUSE
branch
from
02060ec to
adcf772
Compare
bastelfreak
removed
merge-conflicts
tests-fail
needs-work
|
thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for OpenSUSE. Tested on OpenSUSE 15