Allow for installing packages from UNC paths on Windows #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, if a custom forwarder or splunk package source was supplied to the package_source parameter and that package did not need to be staged (because we're targetting an MSI on a UNC path for example), the package installation would fail with a message like: source is required when using package provider 'windows' The reason it failed is because the $package_source variable was not being used as the source of the package. Instead, the $pkg_source variable is used. $pkg_source is only created if the file needs to be staged; which in the case of using Windows and a UNC package source, it does not. This fixes the problem by using the pick() function to choose either $pkg_source or $package_source (in that order) as the source of the package.
Prior to this, the names of the variables used to stage the Splunk Forwarder and Server package were not very clear or descriptive. This commit hopes to clear that up by renaming the variables to better describe their purpose and not have names that conflict with other variable's purposes.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates commits that ultimately allow Windows agents to install packages from UNC paths.
Prior to this, if setting
$package_sourceto a UNC path on Windows, thepackageresource wouldn't ever use the value of$package_sourceas it's source. The reason for that is because a UNC path doesn't need to be staged withstaging::filethus the$pkg_sourcevariable was never set.While I was fixing that problem, I also cleaned up the variable names in the
staging::filesteps to make their intent more clear.