Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump release for 6.0.0 #112

Merged
merged 1 commit into from
May 25, 2017
Merged

Bump release for 6.0.0 #112

merged 1 commit into from
May 25, 2017

Conversation

petems
Copy link
Member

@petems petems commented May 25, 2017

  • Updates CHANGELOG.md

@petems petems requested a review from bastelfreak May 25, 2017 23:16
bastelfreak
bastelfreak reviewed May 25, 2017
View reviewed changes
metadata.json Outdated
@@ -1,6 +1,6 @@
{
"name": "puppet-splunk",
"version": "5.1.1-rc0",
"version": "5.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct PR title but wrong version? :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! 😓

bastelfreak
bastelfreak reviewed May 25, 2017
View reviewed changes
CHANGELOG.md Outdated
* Add missing badges
* Fix several rubocop issues
* Bump min version_requirement for Puppet + deps
## [v5.2.0](https://github.com/voxpupuli/puppet-splunk/tree/v5.2.0) (2017-05-25)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust this as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

bastelfreak
bastelfreak reviewed May 25, 2017
View reviewed changes
CHANGELOG.md Outdated
* Fix several rubocop issues
* Bump min version_requirement for Puppet + deps
## [v5.2.0](https://github.com/voxpupuli/puppet-splunk/tree/v5.2.0) (2017-05-25)
[Full Changelog](https://github.com/voxpupuli/puppet-splunk/compare/v5.1.0...v5.2.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

@petems
Bump release for 6.0.0
22765a6 
* Updates CHANGELOG.md
@bastelfreak bastelfreak merged commit 25c4bce into voxpupuli:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @bastelfreak