Support management of snmptrapd #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elmobp Thanks for the contribution! Could you please add a test that shows what happens when the new parameter is set to |
|
hey @ghoneycutt done! I had to do in multiple places given how the behaviour works. I also swapped the unless to a if statement to make the multiple condition easier to understand. Let me know if this is ok? |
ghoneycutt
reviewed
Nov 17, 2020
ghoneycutt
approved these changes
Nov 17, 2020
|
@elmobp very well done |
|
Test + squash |
kenyon
approved these changes
Nov 17, 2020
bastelfreak
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add support for managing snmptrapd package/config
At the moment there is currently no option to stop shipping the snmpdtrapd package.