Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stdlib to 4.22.0 #179

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Updated stdlib to 4.22.0 #179

merged 2 commits into from
Feb 5, 2019

Conversation

thaylin
Copy link
Contributor

@thaylin thaylin commented Feb 4, 2019

This module requires ensure::service, but ensure::service was not added until stdlib 4.22

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #178

@thaylin
Updated stdlib to 4.22
e1277c0 
This module requires ensure::service, but ensure::service was not added until stdlib 4.22
@Dan33l
Copy link
Member

Dan33l commented Feb 5, 2019

@thaylin Thank you for this PR.
The version should be 4.22.0.
Are you able to add a test in acceptance tests to avoid a regression ?

Dan33l
Dan33l requested changes Feb 5, 2019
View reviewed changes
metadata.json Outdated Show resolved Hide resolved
@ghoneycutt
Copy link
Member 

(ERROR) dependencies: Invalid 'version_requirement' field in metadata.json: Unparsable version range: ">= 4.22 < 6.0.0"
Errors found in metadata.json

Try changing it to 4.22.0

@ghoneycutt ghoneycutt changed the title Updated stdlib to 4.22 Updated stdlib to 4.22.0 Feb 5, 2019
@ghoneycutt ghoneycutt added the bug Something isn't working label Feb 5, 2019
@ghoneycutt
Copy link
Member

Thanks everyone!

@ghoneycutt ghoneycutt merged commit 3415f46 into voxpupuli:master Feb 5, 2019
@ghoneycutt
Copy link
Member

Will merge a release with @alexjfisher later at CfgMgmtCamp today or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan33l Dan33l Dan33l requested changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependancy listings are out of date
4 participants
@thaylin @Dan33l @ghoneycutt @bastelfreak