Replace validation logic for *service_ensure. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Oct 4, 2018
ekohl
reviewed
Oct 4, 2018
vStone
force-pushed
the
feature/ensure_services
branch
4 times, most recently
from
c49c647 to
5c04f7a
Compare
alexjfisher
approved these changes
Oct 4, 2018
ekohl
approved these changes
Oct 4, 2018
manifests/init.pp
Outdated
| $service_enable_real = $trap_service_enable_real | ||
| } else { | ||
| $service_ensure_real = $service_ensure | ||
| $service_enable_real = $service_enable | ||
| } | ||
| } |
Use an Enums to enforce values and remove manual validation in the code
vStone
force-pushed
the
feature/ensure_services
branch
from
5c04f7a to
d07f81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Emums to enforce values and remove manual validation in the code