Fix acceptance tests & run on vagrant_libvirt #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
fix/acceptance-tests
branch
14 times, most recently
from
2512cb8
to
3e86777
Compare
bastelfreak
force-pushed
the
fix/acceptance-tests
branch
2 times, most recently
from
1ad49a5
to
2e1be74
Compare
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
Aug 9, 2024
This was referenced Aug 9, 2024
bastelfreak
force-pushed
the
fix/acceptance-tests
branch
from
2e1be74
to
5d4e809
Compare
Fixes: 28bc41b ("migrater to beaker_puppet_helpers")
bastelfreak
force-pushed
the
fix/acceptance-tests
branch
from
5d4e809
to
795761e
Compare
bastelfreak
changed the title
rwaffen
approved these changes
Aug 9, 2024
traylenator
reviewed
Aug 9, 2024
| <<-EOS | ||
| class { 'selinux': mode => 'disabled' } | ||
| EOS | ||
| end | ||
|
|
||
| context 'before reboot' do | ||
| before(:all) do | ||
| # Tag vagrant user to an administrative group | ||
| shell('semanage login -a -s staff_u vagrant') |
There was a problem hiding this comment.
Is this okay for running elsewhere and the vagrant user might not exist ?
There was a problem hiding this comment.
I don't know enough about it. I think the vagrant user is default for vagrant boxes?
There was a problem hiding this comment.
There's host['user'] so I think this would ensure the correct user is used:
Suggested change
| shell('semanage login -a -s staff_u vagrant') | |
| block_on hosts do |host| | |
| on host, "semanage login -a -s staff_u #{host['user']}" | |
| end |
I get the impression the rest is all single node, so this is probably the equivalent
Suggested change
| shell('semanage login -a -s staff_u vagrant') | |
| shell("semanage login -a -s staff_u #{default['user']}") |
There was a problem hiding this comment.
The vagrant user should be in every vagrant box published, vagrant docs. I am happy either way, if a more general fix works we can do that, or any box published should have that user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a resubmission of #390 but with voxpupuli/gha-puppet#60