Add remaining Puppet data types #357
Conversation
| $file_keystorage_dir = $rundeck::file_keystorage_dir, | ||
| $group = $rundeck::config::group, | ||
| $user = $rundeck::config::user, | ||
| String $path, |
There was a problem hiding this comment.
@juniorsysadmin do you know what this is used for?
The docs say:
# [*path*]
# The actual value (password) of the named key
But then the code has:
$key_fqpath = "${file_keystorage_dir}/content/keys/${path}"
This seems like in either case, maybe it's not supposed to be a full path?
There was a problem hiding this comment.
https://github.com/voxpupuli/puppet-rundeck/blob/master/manifests/config/resource_source.pp#L79 is the one that's driving me a little more crazy. I don't think it can be made undef as it is here, except maybe by using a selector. Maybe we could make it some kind of variant of an empty string or Stdlib::HTTPUrl?
There are a few other empty strings that I'm not sure can be switched to undefs.
There was a problem hiding this comment.
do you know what this is used for?
Absolutely no idea, sorry.
There was a problem hiding this comment.
Looking at my existing Rundeck install, I think this is the username (not password) of the key? That is, there's a directory like /var/lib/rundeck/var/storage/content/keys with a directory for each username. In the case of ec2 credentials, it's like rundeck/ec2/{rundeck_access_key_id,rundeck_secret_access_key} (where the username is rundeck).
|
Perhaps just do loose datatypes in this PR first, then cleanup the code and use more restrictive datatypes in another PR. |
No description provided.