Make private classes explicitly private, prevent setting params via rundeck::config #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what folks think about this, many of the classes have comments that they're private types; I think this makes it more explicit, and makes it impossible to pass params into classes that don't have datatypes.
Edit: was able to work out the issue with rundeck::config as well. Not sure if it was common for folks to pass stuff directly into
rundeck::config
; if so, we should call this breaking, but maybe not necessary, esp. since it was already mentioned in the docs that it's private.Let's merge this before #351