-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix acceptance tests and run in Travis. Resolve idempotency issue #335
Conversation
The split commits are intentional. |
Hrm, the test passes sometimes but fails sometimes on Ubuntu, not sure if it's a flaky source, or the apt ssl issue that's affected some other modules. |
Looks like the https transport is not installed |
I think since modulesync is merged, that will fix it maybe? https://github.com/voxpupuli/puppet-rundeck/blob/master/spec/acceptance/nodesets/docker/ubuntu-16.04.yml#L13 What's odd is that I restarted the build earlier and it passed. |
…plicit dependency on rundeck::config::global::project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's see what Travis thinks
This will add the acceptance tests back to the Travis matrix, simplifies them, and also resolves an idempotency issue on certain platforms.
I believe this will also fix the issue that was causing modulesync to fail.
I switched apt to be a soft dep per https://docs.puppet.com/puppet/5.1/style_guide.html#dependencies and also listed Java as a dependency (the acceptance tests install puppetlabs/java but I don't think the setup requirements mentioned it).