Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance tests and run in Travis. Resolve idempotency issue #335

Merged
merged 4 commits into from
Sep 17, 2017
Merged

Fix acceptance tests and run in Travis. Resolve idempotency issue #335

merged 4 commits into from
Sep 17, 2017

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 16, 2017

This will add the acceptance tests back to the Travis matrix, simplifies them, and also resolves an idempotency issue on certain platforms.

I believe this will also fix the issue that was causing modulesync to fail.

I switched apt to be a soft dep per https://docs.puppet.com/puppet/5.1/style_guide.html#dependencies and also listed Java as a dependency (the acceptance tests install puppetlabs/java but I don't think the setup requirements mentioned it).

@wyardley
Copy link
Contributor Author

The split commits are intentional.
may need to be re-run after #336 is merged.

@wyardley
Copy link
Contributor Author

Hrm, the test passes sometimes but fails sometimes on Ubuntu, not sure if it's a flaky source, or the apt ssl issue that's affected some other modules.

@ekohl
Copy link
Member

ekohl commented Sep 16, 2017

       	Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: E: The method driver /usr/lib/apt/methods/https could not be found.

Looks like the https transport is not installed

@wyardley
Copy link
Contributor Author

Looks like the https transport is not installed

I think since modulesync is merged, that will fix it maybe?

https://github.com/voxpupuli/puppet-rundeck/blob/master/spec/acceptance/nodesets/docker/ubuntu-16.04.yml#L13
But I feel like with another module there might have been some additional changes needed to make this work right (maybe version of the apt module?
https://github.com/voxpupuli/puppet-rundeck/blob/master/metadata.json#L72 (should also be a soft dep)

What's odd is that I restarted the build earlier and it passed.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see what Travis thinks

@wyardley wyardley merged commit 99df53a into voxpupuli:master Sep 17, 2017
@wyardley wyardley deleted the fix_acceptance_tests branch September 17, 2017 00:37
@wyardley wyardley added the bug Something isn't working label Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants