Automate configuration of SCM export properties in a project #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,8 @@ | |||
| $node_executor_settings = {}, | |||
| $projects_dir = undef, | |||
| $resource_sources = $rundeck::resource_sources, | |||
| $scm_import_properties = $rundeck::scm_import_properties, | |||
| $scm_import_properties = {}, | |||
There was a problem hiding this comment.
Do blank hashes/arrays in parameterized class variables still break hiera?
There was a problem hiding this comment.
@jyaworski - yes, they break in the current implementation. In the template, the hash is iterated over like this:
<%- @scm_export_properties.sort.each do |k,v| -%>
<%= k %> = <%= v %>
<%- end -%>
If the hash is empty (which it may be if the user does not have a need to configure the SCM for a certain project), provisioning would fail on a null hash if it was not defaulted to '{}' here.
There was a problem hiding this comment.
What I mean is that hiera's automatic lookups are known to fail on blank array defaults. Do they fail with blank hash defaults?
There was a problem hiding this comment.
Null hash values or hashes with keys that have null values work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
rundeck::config::projectwhen it is desired to pre-specify the SCM configuration for exporting Rundeck jobsscm-export.properties.erbtemplate