Remove auth-constraint from web.xml if preauthenticated mode enabled

[danifr]

When I opened the PR for configuring preauthenticated mode (#175), I forgot this:

From the rundeck docs:
The file WEB-INF/web.xml inside the war contents must be modified to remove the <auth-constraint> element. This disables the behavior which causes the Container to trigger its authentication mechanism when a user browses to a Rundeck page requiring authorizaton.

This patch should take of it.

[jyaworski]

Can you add something to reinstate it if one chooses to not use preauthenticated mode?

[danifr]

@jyaworski let me know what you think

[jyaworski]

Is there a way to do this without an onlyif?

https://projects.puppetlabs.com/projects/1/wiki/puppet_augeas#A-Better-Way

If not, it's not a blocker.

[jyaworski]

Tests fail.

[danifr]

Tests are broken. Even master fails.

11:31:22-root~/gits/puppet-rundeck (master)$ bundle exec rake $CHECK
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
fatal: destination path 'spec/fixtures/modules/inifile' already exists and is not an empty directory.
fatal: destination path 'spec/fixtures/modules/archive' already exists and is not an empty directory.
fatal: destination path 'spec/fixtures/modules/stdlib' already exists and is not an empty directory.
/usr/bin/ruby -I/usr/local/share/gems/gems/rspec-core-3.4.3/lib:/usr/local/share/gems/gems/rspec-support-3.4.1/lib /usr/local/share/gems/gems/rspec-core-3.4.3/exe/rspec --pattern spec/\{classes,defines,unit,functions,hosts,integration,types\}/\*\*/\*_spec.rb --color

rundeck
  supported operating systems
    rundeck::config::global::aclpolicyfile class without any parameters on Debian
      should contain File[/etc/rundeck/admin.aclpolicy] with content  supplied string (FAILED - 1)
    rundeck::config::global::aclpolicyfile class without any parameters on RedHat
      should contain File[/etc/rundeck/admin.aclpolicy] with content  supplied string (FAILED - 2)
...

Same for #192

[jyaworski]

I'm going to revert it. It's a lot more sinister to fix than I originally thought.

On Mar 8, 2016, at 5:41 AM, Daniel [email protected] wrote:

Tests are broken. Even master fails.

11:31:22-root~/gits/puppet-rundeck (master)$ bundle exec rake $CHECK
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
fatal: destination path 'spec/fixtures/modules/inifile' already exists and is not an empty directory.
fatal: destination path 'spec/fixtures/modules/archive' already exists and is not an empty directory.
fatal: destination path 'spec/fixtures/modules/stdlib' already exists and is not an empty directory.
/usr/bin/ruby -I/usr/local/share/gems/gems/rspec-core-3.4.3/lib:/usr/local/share/gems/gems/rspec-support-3.4.1/lib /usr/local/share/gems/gems/rspec-core-3.4.3/exe/rspec --pattern spec/{classes,defines,unit,functions,hosts,integration,types}/**/*_spec.rb --color

rundeck
supported operating systems
rundeck::config::global::aclpolicyfile class without any parameters on Debian
should contain File[/etc/rundeck/admin.aclpolicy] with content supplied string (FAILED - 1)
rundeck::config::global::aclpolicyfile class without any parameters on RedHat
should contain File[/etc/rundeck/admin.aclpolicy] with content supplied string (FAILED - 2)
...
Same for #192

—
Reply to this email directly or view it on GitHub.