fixes for RabbitMQ 3.4.0 #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitmqctl's list commands, so this change checks to see if the split command output ends with "...done." and slices the array appropriately
|
I can confirm that the installation where I had to comment out rabbitmq_user { 'sensu': } and the rabbitmq_vhost { 'sensu': } resources due to an idempotence bug is using: ii rabbitmq-server 3.4.0-1 all AMQP server written in Erlang |
|
hrm... we'll need to synchronize this with #251 depending on which lands first. |
|
This one is really affecting us. Can this one (or #251) get merged on short notice? |
|
This one is critical to us as well. Could it be merged quickly and a release be made, please? |
queeno
added a commit
to queeno/puppet-uchiwa
that referenced
this pull request
Nov 10, 2014
The puppetlabs/rabbitmq (v 3.4.0 puppet module is incompatible with rabbitmq 4.1. There is a PR open to make the puppetlabs module support the latest version of rabbitmq: voxpupuli/puppet-rabbitmq#250 Until a new puppetlabs/rabbitmq release comes out, we should install rabbitmq 3.3.5 when we run the beaker tests.
queeno
added a commit
to queeno/puppet-uchiwa
that referenced
this pull request
Nov 10, 2014
The puppetlabs/rabbitmq (v 3.4.0 puppet module is incompatible with rabbitmq 4.1. There is a PR open to make the puppetlabs module support the latest version of rabbitmq: voxpupuli/puppet-rabbitmq#250 Until a new puppetlabs/rabbitmq release comes out, we should install rabbitmq 3.3.5 when we run the beaker tests.
|
so, unsurprisingly, this now needs a rebase. |
|
This was fixed in #251 by adding the -q flag to the rabbitmqctl command. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ 3.4.0 and higher do away with the "...done." at the end of rabbitmqctl's list commands, so this change checks to see if the split command output ends with "...done." and slices the array appropriately.