Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Dont pin pip to an outdated version and don't force python3 package installation #706

Merged
merged 2 commits into from
Nov 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions spec/acceptance/pip_spec.rb
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ class { 'python':
ensure => 'present',
systempkgs => false,
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent package':
@@ -47,7 +46,6 @@ class { 'python':
ensure => 'present',
systempkgs => false,
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent package install':
@@ -78,15 +76,13 @@ class { 'python':
it 'throws an error' do
pp = <<-PUPPET
class { 'python':
version => '3',
dev => 'present',
dev => 'present',
}
python::pyvenv { '/opt/test-venv':
ensure => 'present',
systempkgs => false,
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent package':
@@ -116,7 +112,6 @@ class { 'python':
ensure => 'present',
systempkgs => false,
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent package via extra_index':
6 changes: 0 additions & 6 deletions spec/acceptance/pyvenv_spec.rb
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
}
PUPPET

@@ -58,7 +57,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent' :
ensure => 'latest',
@@ -98,7 +96,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent' :
virtualenv => '/opt/agent/venv',
@@ -135,7 +132,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent' :
virtualenv => '/opt/agent/venv',
@@ -172,7 +168,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
}
python::pip { 'agent' :
ensure => '0.1.2',
@@ -220,7 +215,6 @@ class { 'python':
owner => 'agent',
group => 'agent',
mode => '0755',
pip_version => '<= 20.3.4',
python_path => '/usr/bin/mycustompython',
}
python::pip { 'agent' :

Unchanged files with check annotations Beta

{

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system CentOS 7

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system CentOS 8

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system Debian 10

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system FreeBSD 11

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system FreeBSD 12

Check warning on line 1 in metadata.json

GitHub Actions / Puppet / Static validations

Skipping EOL operating system Ubuntu 18.04
"name": "puppet-python",
"version": "7.3.1-rc0",
"author": "Vox Pupuli",