Make latest version detection portable #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently broken on FreeBSD do to the usage of GNU-grep specific grep(1) flag: `-P`. We can use a single sed(1) command with an extended regular expression to achieve the same goal, so use this instead.
smortex
commented
Jan 1, 2024
| @@ -220,7 +220,7 @@ | |||
| $latest_version = join([ | |||
| "${pip_install} ${legacy_resolver} ${pypi_index} ${pypi_extra_index} ${proxy_flag}", | |||
| " ${install_args} ${install_editable} ${real_pkgname}==notreallyaversion 2>&1", | |||
| ' | grep -oP "\(from versions: .*\)" | sed -E "s/\(from versions: (.*?, )*(.*)\)/\2/g"', | |||
| " | sed -nE 's/.*\\(from versions: (.*, )*(.*)\\)/\\2/p'", | |||
There was a problem hiding this comment.
-nprevent output by default (this allows us to skip grep(1) which was used to only process the line matching 'from versions';- The removed
?repetition char (0 or 1) was bogus after the*repetition char (0 or any number), so drop it; - the
gflag is used to replace each occurrences, but we can only have a single match on a line, to remove it and add thepflag to print the result of the substitution which is not done automatically because of 1. above.
kenyon
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently broken on FreeBSD do to the usage of GNU-grep specific
grep(1) flag:
-P.We can use a single sed(1) command with an extended regular expression
to achieve the same goal, so use this instead.