Rocky does not have a separate venv package #665
Conversation
Heidistein
force-pushed
the
master
branch
2 times, most recently
from
9d4bef8 to
6266172
Compare
| @@ -35,7 +35,7 @@ | |||
| ## | |||
| ## CentOS has no extra package for venv | |||
| ## | |||
| unless $facts['os']['name'] == 'CentOS' { | |||
| unless $facts['os']['name'] in ['CentOS', 'Rocky'] { | |||
There was a problem hiding this comment.
This is probably true for Alma as well? Can't we check for os family RedHat instead?
There was a problem hiding this comment.
I have currently no way to check Alma nor RH. I suspect it is true, but I have no way to find out.
There was a problem hiding this comment.
I must not lie. It is also true for alma. Redhat has recently closed its source, unable to check them. Do you know the familyname for alma?
There was a problem hiding this comment.
Adding "AlmaLinux" and "Rocky" to metadata.json (using version "8" I guess?) will run the acceptance tests against these OS and report success / failure.
There was a problem hiding this comment.
suggesting to use OS family instead
unless $facts['os']['family'] == 'RedHat'
should work for RHEL, CentOS Stream, AlmaLinux, RockyLinux,...
There was a problem hiding this comment.
Good idea. will fix, update, change today or friday.
kenyon
changed the title
|
It seems that this is superseded by #677, correct? |
|
Thanks for the confirmation, then I'll close this one, as #677 is already merged and fixes the issues described here in a general manner for the whole RedHat family. Thanks a lot for your contribution! |
This PR fixes the
ensure => presenton the python-venv package on rocky linux. It does, like CentOS, not have a seperate venv package.