Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use legacy pip resolver for pip versions < 21.1 > 20.2.4 #639

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

saz
Copy link
Contributor

@saz saz commented Jul 23, 2022

Pull Request (PR) description

This PR adds the flag --use-deprecated=legacy-resolver to pip install commands, if pip version is below 21.1 and higher than 20.2.4

This Pull Request (PR) fixes the following issues

Fixes #638

@saz saz force-pushed the pip-resolver branch 2 times, most recently from 41422f0 to 6f217f5 Compare July 23, 2022 13:40
@saz saz force-pushed the pip-resolver branch 2 times, most recently from cd9f70f to 6dfeba6 Compare July 25, 2022 12:43
@saz saz requested a review from bastelfreak July 25, 2022 13:23
@saz
Copy link
Contributor Author

saz commented Sep 8, 2022

@bastelfreak Another review, please

@bastelfreak
Copy link
Member

@saz can you please rebase against our latest master to get rid of the merge commit?

@saz
Copy link
Contributor Author

saz commented Sep 8, 2022

I did that yesterday and don't see any conflict? 🤔

@bastelfreak bastelfreak added the bug Something isn't working label Sep 8, 2022
@bastelfreak bastelfreak merged commit b7236a8 into voxpupuli:master Sep 8, 2022
@saz saz deleted the pip-resolver branch November 7, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puppet tries to install latest version of a pip package on every run
2 participants