Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 5.1.0 & puppet-lint: fix params_empty_string_assignment #631

Merged
merged 4 commits into from
Dec 10, 2021
Merged

modulesync 5.1.0 & puppet-lint: fix params_empty_string_assignment #631

merged 4 commits into from
Dec 10, 2021

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member Author

IMO the switch from '' to undef for the parameters isn't a breaking change. But I didn't add the modulesync label on purpose, so this shows up in the changelog.

@bastelfreak bastelfreak mentioned this pull request Dec 10, 2021
Merged
@bastelfreak bastelfreak merged commit 60db389 into master Dec 10, 2021
@bastelfreak bastelfreak deleted the modulesync branch December 10, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuningYourCode TuningYourCode TuningYourCode approved these changes

@mmerfort mmerfort mmerfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @mmerfort @TuningYourCode