Add Support for RedHat/CentOS 8 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Dec 14, 2020
bastelfreak
reviewed
Dec 14, 2020
manifests/params.pp
Outdated
| @@ -10,7 +10,11 @@ | |||
| } | |||
|
|
|||
| $ensure = 'present' | |||
| $version = 'system' | |||
| if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '8' { | |||
| $version = '3' | |||
There was a problem hiding this comment.
feels like we should change $version to '3' as default for all platforms. We set that in the acceptance tests and don't test anything else. (should be changed in another PR)
There was a problem hiding this comment.
I think the exception should be EL7 because it feels wrong to do something different than what ships with a standard install of the OS. I think the logic could just be if EL7 , version=2 else version=3.
There was a problem hiding this comment.
I will try to do that in another PR
|
@bastelfreak I've rebased |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Ad support for RedHat / CentOS 8
This Pull Request (PR) fixes the following issues
This will cause conflicts with #593 so whichever is merged last will have to be rebased to fix conflicts.