enhance pyvenv tests #590
enhance pyvenv tests #590
Conversation
bastelfreak
force-pushed
the
pipfoo
branch
2 times, most recently
from
f41f1e7 to
4c62380
Compare
| apply_manifest(pp, catch_failures: true) | ||
| apply_manifest(pp, catch_changes: true) | ||
| end | ||
| describe command('/opt/agent/venv/bin/pip list') do |
There was a problem hiding this comment.
https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecemptylineafterexample and https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecemptylineafterexamplegroup suggests the same needs to happen here.
There was a problem hiding this comment.
I don't mind adding it, but rubocop doesn't complain at the moment:
$ bundle exec rake rubocop:auto_correct
Running RuboCop...
Inspecting 20 files
Parser::Source::Rewriter is deprecated.
Please update your code to use Parser::Source::TreeRewriter instead
....................
20 files inspected, no offenses detected
There was a problem hiding this comment.
This does make it harder to read. I'd say to add the space and then consider adding that check to modulesync
There was a problem hiding this comment.
I don't mind adding it, but rubocop doesn't complain at the moment:
I suspect this is because the version is too old to contain it.
| apply_manifest(pp, catch_failures: true) | ||
| apply_manifest(pp, catch_changes: true) | ||
| end | ||
| describe command('/opt/agent/venv/bin/pip list') do |
There was a problem hiding this comment.
This does make it harder to read. I'd say to add the space and then consider adding that check to modulesync
|
added it |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues