General linting/indent/syntax #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazymind1337
force-pushed
the
general_linting_and_syntax
branch
2 times, most recently
from
689644c to
542e9ff
Compare
crazymind1337
force-pushed
the
general_linting_and_syntax
branch
2 times, most recently
from
37863d0 to
784386d
Compare
bastelfreak
reviewed
Nov 17, 2020
crazymind1337
force-pushed
the
general_linting_and_syntax
branch
6 times, most recently
from
301985c to
d936501
Compare
|
can we open up some follow up issues for the findings, before merging this and forgetting about it forever |
igalic
approved these changes
Nov 18, 2020
crazymind1337
force-pushed
the
general_linting_and_syntax
branch
from
d936501 to
7520a85
Compare
|
This was referenced Nov 18, 2020
|
added two more issues |
bastelfreak
reviewed
Dec 2, 2020
| Any $src = false, | ||
| Array $environment = [], | ||
| Boolean $forceupdate = false, | ||
| Stdlib::Absolutepath $cwd = undef, |
There was a problem hiding this comment.
this is a backwards-incompatible change. previously you did not need to set a cwd, now it's mandatory. this should be fixed. In the meantime I added the backwards-incompatible label here.
bastelfreak
added a commit
to bastelfreak/puppet-python
that referenced
this pull request
Dec 3, 2020
This was optional before voxpupuli#580 was merged.
bastelfreak
added a commit
to bastelfreak/puppet-python
that referenced
this pull request
Dec 3, 2020
This was optional before voxpupuli#580 was merged.
|
fixed it in #587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just adjusted the manifests to current code style. There should not be any compatibility changes.