Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CentOS 6 support #566

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Drop CentOS 6 support #566

merged 1 commit into from
Sep 14, 2020

Conversation

bastelfreak
Copy link
Member

We don't run acceptance tests for CentOS 6 since a long time.
In #564 we tried to
enable the acceptance tests again but they don't work.

  • CentOS 6 ships Python 2.6 which is EOL since ages
  • CentOS 6 is EOL by end of the year anyway
  • We already support CentOS 7

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

We don't run acceptance tests for CentOS 6 since a long time.
In voxpupuli#564 we tried to
enable the acceptance tests again but they don't work.

* CentOS 6 ships Python 2.6 which is EOL since ages
* CentOS 6 is EOL by end of the year anyway
* We already support CentOS 7
@igalic
Copy link
Contributor

igalic commented Sep 13, 2020

it's one thing to not run acceptance tests for it, but an entirely different beast to drop support before the EOL date


not that i approve of the practice, but a lot of companies running CentOS or RHEL, are probably still running 5 (and that's not a typo)

@bastelfreak
Copy link
Member Author

I dont know if this even still works on CentOS 6. the tests arent present since a long time. And I think as a community we should not encourage people to use outdated software. And we should not claim CentOS 6 support in the metadata.json if we know that the tests dont pass. If anyone wants to fix them, thats fine by me. But I also think we ahould drop support as soon as it is end of life (which we also did in the past). The EoL date fot CentOS 6 is soon.

@ghoneycutt
Copy link
Member

I mentioned we should drop EL6 in #563 though didn't realize it was not fully EOL yet. Agree with @igalic that we should not deprecate before the actual EOL.

Also agree with @bastelfreak that if the tests do not actually pass, we have two options, stop saying we support something we do not, or do the work to support it. I'm OK with either and suggest we merge this. This does not preclude anyone from properly adding EL6 support.

@igalic igalic merged commit 9701bd0 into voxpupuli:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants