-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix facts for python rc version #468
base: master
Are you sure you want to change the base?
Fix facts for python rc version #468
Conversation
@krissik can you please rebase and maybe add a test for this? |
Dear @krissik, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
f29edbd
to
2a03f66
Compare
Can someone point me to an example of how to test a fact? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have tests for this?
if we do, we should extend them, if we don't, we should.
duh
i am not the first to say this, but you can't delete a review, not even a bad one
I will add tests but I do not know how. An example would be helpfull or some documentation. |
|
Change regex in
python_version
andpython_release
facts so it matches python release candidate version (e.g. Python 2.7.16rc1, Python 3.7.3rc1).