Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facts for python rc version #468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krissik
Copy link
Contributor

@krissik krissik commented Mar 25, 2019

Change regex in python_version and python_release facts so it matches python release candidate version (e.g. Python 2.7.16rc1, Python 3.7.3rc1).

@bastelfreak
Copy link
Member

@krissik can you please rebase and maybe add a test for this?

@bastelfreak bastelfreak added bug Something isn't working needs-rebase needs-tests labels Apr 26, 2020
@vox-pupuli-tasks
Copy link

Dear @krissik, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@krissik krissik force-pushed the fix-fact-python-releasecandiate-version branch from f29edbd to 2a03f66 Compare July 30, 2020 06:06
@krissik
Copy link
Contributor Author

krissik commented Jul 31, 2020

Can someone point me to an example of how to test a fact?

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have tests for this?
if we do, we should extend them, if we don't, we should.


duh
i am not the first to say this, but you can't delete a review, not even a bad one

@krissik
Copy link
Contributor Author

krissik commented Jul 31, 2020

I will add tests but I do not know how. An example would be helpfull or some documentation.

@igalic
Copy link
Contributor

igalic commented Jul 31, 2020

14:29 <meena> how do we rspec test facts? 
14:39 <ewoud> with pain
14:40 <ewoud> there's some boiler plate to clear facts before/after
14:42 <ewoud> https://github.com/voxpupuli/puppet-yum/blob/master/spec/unit/facter/yum_package_updates_spec.rb is probably a decent example
14:43 <ewoud> it is also one of the few examples that uses subject {}, most of them call Facter.fact() every time
14:43 <ewoud> maybe it should clear facts before rather than after though
14:44 <ewoud> it would be great if rspec-puppet provided some nice integration like it does with classes, defines, etc
14:48 <meena> yeah, that seems oddly asymmetric 

so, yeah, https://github.com/voxpupuli/puppet-yum/blob/master/spec/unit/facter/yum_package_updates_spec.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants