Add manage_scl boolean to control managing SCL #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 27, 2019
manifests/install.pp
Outdated
| default => 'absent', | ||
| } | ||
| if $python::manage_scl { | ||
| $install_scl_repo_package = $::operatingsystem ? { |
There was a problem hiding this comment.
the topscope fact is deprecated. could you migrate it to $facts['os']['name']?
bastelfreak
added
enhancement
|
Test failures appear unrelated to the change. |
|
thanks! |
|
If we can get a release with this change in, that would be awesome. |
|
I'm working on a new release. That depends on #467 |
|
Any chance of that release now that #467 has been merged? |
|
Actually, scratch that for now, this module is still broken WRT to using SCL versions. I'll raise another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This adds a
manage_sclboolean which can be set tofalseto stop managing the various SCL packages in the case some other module is doing that already.This Pull Request (PR) fixes the following issues
Fixes #463