Allow custom python versions and environments #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jradmacher
force-pushed
the
allow_custom_versions
branch
3 times, most recently
from
a433a6c to
0de1e57
Compare
|
Hi @jradmacher, could you please squash the commits down a bit? Otherwise this looks good! |
|
Please also have a look at the used email address in the commits. It isn't associated with your github account. |
jradmacher
force-pushed
the
allow_custom_versions
branch
from
6af4cb8 to
827f573
Compare
|
Squashed to 4 commits. I don't want create fewer commits, as each commit introduces a non trivial behavior change. Could you rerun the TravisCI build? It failed with an unrelated VM error. |
bastelfreak
reviewed
Jan 2, 2019
bastelfreak
added
needs-feedback
jradmacher
force-pushed
the
allow_custom_versions
branch
from
827f573 to
5c5ac01
Compare
"python3 -m venv" is the recommended replacement since 3.6 pyvenv will be removed in 3.8 Debian (+Ubuntu) need an extra package for the script and the _not deprecated_ python module
This should fix the first part of issue voxpupuli#430 "pip3 missing in the virtualenv ?" using a proxy for download is not addressed here
Fixes issue voxpupuli#448, "Impossible to use version number in Ubuntu 16.04" 1) It does not make sense to restrict the allowed python versions per distribution. Newer distribution releases add new python versions and you can add repositories containing backports. 2) The List was outdated. Note: python version is needed for spec test
to create two or more venvs without duplicate declaration error
jradmacher
force-pushed
the
allow_custom_versions
branch
from
e70b9a6 to
5ea5621
Compare
|
Updates:
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request allows to install all python versions and create pyenv or virtualenv environments
with those versions.
This also adds the missing venv module in newer Debian based distributions and addresses the deprecation of pyenv in 3.6 with an expected removal of it in Python 3.8.
This Pull Request (PR) fixes the following issues
Fixes #448
Fixes the first part of #430 "pip3 missing in the virtualenv ?"