CentOS Acceptance testing, and more.... #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ekohl
approved these changes
Aug 14, 2018
manifests/install.pp
Outdated
| @@ -46,6 +40,21 @@ | |||
| default => $python::virtualenv, | |||
| } | |||
|
|
|||
| if ($venv_ensure == 'present') { | |||
| $dev_ensure = 'present' | |||
| if ! $python::dev { | |||
There was a problem hiding this comment.
if ! can also be written as unless
manifests/install.pp
Outdated
| @@ -46,6 +40,21 @@ | |||
| default => $python::virtualenv, | |||
| } | |||
|
|
|||
| if ($venv_ensure == 'present') { | |||
There was a problem hiding this comment.
I prefer to leave out braces unless they are really needed
ekohl
approved these changes
Aug 15, 2018
bastelfreak
reviewed
Aug 19, 2018
| @@ -58,6 +58,7 @@ PrePush: | |||
| enabled: true | |||
| description: 'Run rake targets' | |||
| targets: | |||
| - 'validate' | |||
There was a problem hiding this comment.
can you provide this change to https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.overcommit.yml.erb as well?
There was a problem hiding this comment.
|
Thanks @danquack ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Enhancing #419, I added CentOS to the list of rake acceptances testing and README. In doing so I encounted the error in comments, and so therefore modified the install, that if you include a virtual environment, you must have the development package.
External to the issues described below, I also modified the overcommit file to add puppet validation.
This Pull Request (PR) fixes the following issues
Fixes #423
Fixes #402