Add support for providing pip provider #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
bastelfreak
reviewed
Jul 8, 2018
README.md
Outdated
| @@ -77,6 +87,8 @@ Installs and manages packages from pip. | |||
|
|
|||
| **virtualenv** - virtualenv to run pip in. Default: system (no virtualenv) | |||
|
|
|||
| **pip_provider** - pip provder to execute pip with. Default: pip. | |||
There was a problem hiding this comment.
there is a tiny typo: provder -> provider
bastelfreak
reviewed
Jul 8, 2018
manifests/pip.pp
Outdated
| # | ||
| define python::pip ( | ||
| $pkgname = $name, | ||
| $ensure = present, | ||
| $virtualenv = 'system', | ||
| $pip_proivder = 'pip', |
There was a problem hiding this comment.
Can you please add a dadatype for this new parameter? An enum would be awesome, otherwise String works as well.
bastelfreak
reviewed
Jul 8, 2018
manifests/requirements.pp
Outdated
| # | ||
| define python::requirements ( | ||
| $requirements = $name, | ||
| $virtualenv = 'system', | ||
| $pip_provider = 'pip', |
There was a problem hiding this comment.
same here, please add a datatype
bastelfreak
added
enhancement
|
Hi @danquack, thanks for the PR! Can you please take a look at the used email address in your commit? It isn't associated with your github account. Can you also extend the current tests to validate variations of the new parameters? |
|
Hi @danquack, you can probably fix the rubocop errors with: |
|
@bastelfreak copying over to a different fork to consolidate numerous git commits #414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fixes #303