quick fix for failing travis builds #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
May 10, 2017
.travis.yml
Outdated
| @@ -38,7 +38,8 @@ env: | |||
| - PUPPET_GEM_VERSION="~> 4.6.0" | |||
| - PUPPET_GEM_VERSION="~> 4.7.0" | |||
| - PUPPET_GEM_VERSION="~> 4.8.0" | |||
| - PUPPET_GEM_VERSION="~> 4" | |||
There was a problem hiding this comment.
we want to keep this so that we always test against the newest version
ghoneycutt
reviewed
May 10, 2017
.travis.yml
Outdated
| @@ -38,7 +38,8 @@ env: | |||
| - PUPPET_GEM_VERSION="~> 4.6.0" | |||
| - PUPPET_GEM_VERSION="~> 4.7.0" | |||
| - PUPPET_GEM_VERSION="~> 4.8.0" | |||
| - PUPPET_GEM_VERSION="~> 4" | |||
| - PUPPET_GEM_VERSION="~> 4.9.0" | |||
There was a problem hiding this comment.
Thanks for adding 4.9 and 4.10
ghoneycutt
reviewed
May 10, 2017
Gemfile
Outdated
| @@ -18,7 +18,7 @@ else | |||
| gem 'facter', :require => false | |||
| end | |||
|
|
|||
| gem 'puppetlabs_spec_helper', '>= 1.2.0', :require => false | |||
| gem 'puppetlabs_spec_helper', '>= 1.2.0', '<= 1.2.2', :require => false | |||
There was a problem hiding this comment.
gem 'puppetlabs_spec_helper', '2.0.2', :require => false if RUBY_VERSION >= '1.8.7' && RUBY_VERSION < '1.9'
gem 'puppetlabs_spec_helper', '>= 2.0.0', :require => false if RUBY_VERSION >= '1.9'
ghoneycutt
reviewed
May 10, 2017
| anchor { 'python::end': } | ||
| anchor { 'python::begin': } | ||
| -> class { 'python::install': } | ||
| -> class { 'python::config': } |
|
Thanks for the help; it should pass for real this time. 👍 |
|
@7yl4r seems like |
|
You're exactly right, @flokli . It should be an easy fix I plan to come back around to this project and resolve soon. |
|
@7yl4r If you currently don't have the time, I could take a look at this. Just let me know :-) |
|
Thanks everyone! Similar functionality added in PR #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
Although the better fix re (1) might be to switch over to using the newer spec_helper, at least this will allow tests to pass in the meantime.
Closes #372 .