EL7 use python2-pip package name

[david-caro]

It turns out that the package name has changed in the epel repository.
closes #348

Signed-off-by: David Caro [email protected]

[schwicke]

This certainly would do the job. I wonder though if it would not be a good idea to allow the user to pass on the package name as a parameter. This way, it may be possible to simplify the code a bit.

[david-caro]

I agree that is a good idea, and that it would have allowed me to work around the issue, though to me that should be the last resource for the user, it should pick the good package by default.

[ghoneycutt]

Thank you for your contribution! Could you please add a spec test so that we can merge this change.

[ghoneycutt]

@schwicke The package name should definitely be a parameter, though we also want to have sane defaults for our supported platforms so that when you use the module, it does the right thing out of the box without having to specify data.

[ju5t]

You probably missed #346 when writing this pull request. Feel free to reuse the test I wrote.

I would recommend versioncmp() over a regex on the wrong fact. You can use $::operatingsystemmajrelease instead.

[ghoneycutt]

Hi,

Could someone please do a functional test of the code from #347 and verify that it works to solve this problem?

[ghoneycutt]

@david-caro Thanks for the contribution though going with PR #347 since it had spec tests. We could still use your help by verifying that the code in PR #347 works.

[david-caro]

@ghoneycutt I did not see it, I think I searched on the issues but not the PRs. No problem 👍

[schwicke]

@ghoneycutt fully agree, I think the module should both provide sensible (working) defaults and the option to name the package as a parameter. That would be nice to have.