Allow hiera config for dotfiles #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Dec 8, 2016
| @@ -81,6 +81,7 @@ | |||
| $python_virtualenvs = { }, | |||
| $python_pyvenvs = { }, | |||
| $python_requirements = { }, | |||
| $python_dotfiles = { }, | |||
There was a problem hiding this comment.
this needs to be validated. Please add validate_hash($python_dotfiles) to the manifest.
There was a problem hiding this comment.
hash validation has been added for $python_dotfiles, thanks
|
Thanks @puppetninja The tests that are failing are not related to your PR. I am working on fixing them in PR #345 |
|
Would one of you mind testing this PR to ensure it does what it is supposed to? I'd like to get confirmation from someone before merging. |
puppetninja
force-pushed
the
hiera-dotfile
branch
from
fe4f9d4 to
6eda9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.