RHSCL Repository installation made optional #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the switch is useful if the repository is already configured independent of this module
* fixed bug with puppet 3.8.7/--parser future by using a qualified path name for scl Error: Validation of Exec[python_requirements_initial_install_...] failed: 'scl enable rh-python34 -- ...' is not qualified and no path was specified. Please qualify the command or specify a path. at /tmp/vagrant-puppet/.../python/manifests/virtualenv.pp:173 install.pp * added virtualenv specific package for rhscl virtualenv.pp * fixed version not prepended with "python" - will fail for rhscl (version = "rh-python34" for example)
* version for virtualenv is not the same as for python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this proposal contains the following changes to puppet-python:
1.) add a switch to prevent the yum repository provisioning of SCL
2.) fixed bug with puppet 3.8.7/--parser future by using a qualified path name for scl
Error: Validation of Exec[python_requirements_initial_install_...] failed: 'scl enable rh-python34 -- ...' is not qualified and no path was specified. Please qualify the command or specify a path. at /tmp/vagrant-puppet/.../python/manifests/virtualenv.pp:173
Please review my changes and give me feedback if you are willed to merge them, or if you would like to have changes on the current implementation.
Greetings,
Michael