fix pip failing in virtualenv under SCL #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possibly this is the issue in #234 as well |
mbmilligan
force-pushed
the
mbmilligan-pip-scl
branch
from
2a6acf3 to
42a66fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a virtualenv is created from an SCL python installation, that python binary needs to be runnable for commands in that virtualenv to work. At present this will fail if there is not a matching version of libpython installed in a system path. (Example: python3 is installed via SCL on a system without any version of python3 installed in the base system.)
scl enableamong other things, sets LD_LIBRARY_PATH, and thus needs to be invoked when running pip.exec_prefixshould always be empty when SCL is not in use, so this should be a safe change.