Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 146 #154

Merged
merged 3 commits into from
Nov 29, 2014
Merged

Revert 146 #154

merged 3 commits into from
Nov 29, 2014

Conversation

shivapoudel
Copy link
Contributor

No description provided.

shivapoudel added a commit that referenced this pull request Nov 29, 2014
@shivapoudel
Merge pull request #154 from stankevich/revert-146
b12223d 
Revert 146
@shivapoudel shivapoudel merged commit b12223d into master Nov 29, 2014
@shivapoudel shivapoudel deleted the revert-146 branch November 29, 2014 12:41
@shivapoudel
Copy link
Contributor Author

Fixes #151 and #153 :)

@cmeury
Copy link

cmeury commented Dec 2, 2014

However with this merge we're to this error on a new node:
Error: Could not retrieve local facts: uninitialized constant Gem Error: Failed to apply catalog: Could not retrieve local facts: uninitialized constant Gem
So I don't understand how reverting the require 'rubygems' helped?

@shivapoudel shivapoudel restored the revert-146 branch December 2, 2014 10:28
@shivapoudel shivapoudel deleted the revert-146 branch December 2, 2014 10:28
@shivapoudel shivapoudel mentioned this pull request Dec 2, 2014
Merged
shivapoudel pushed a commit that referenced this pull request Sep 1, 2015
Merge pull request #154 from stankevich/revert-146
9cb664f 
Revert 146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivapoudel @cmeury