Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for ticket 66: allow extra arguments when using requirement... #114

Merged
merged 1 commit into from
Aug 13, 2014

Conversation

neilkatin
Copy link

...s

Adds an extra argument "extra_pip_args" that can be set to any string; it will be included after
the requirements file is specified to allow (for example) non pypi packages to be built.

…ents

Adds an extra argument "extra_pip_args" that can be set to any string; it will be included after
the requirements file is specified to allow (for example) non pypi packages to be built.
@shivapoudel
Copy link
Contributor

@neilkatin Travis CI build is failed. Thanks! tough I review the PR throughly.

@shivapoudel
Copy link
Contributor

@neilkatin one notice for you $extra_pip_args should be used as ${extra_pip_args}. I'll merge your PR in so you get the credit, but it won't look very similar to what you submitted.

shivapoudel added a commit that referenced this pull request Aug 13, 2014
Proposed fix for ticket 66: allow extra arguments when using requirement...
@shivapoudel shivapoudel merged commit 4c4c9ed into voxpupuli:master Aug 13, 2014
@shivapoudel
Copy link
Contributor

Fixes #66

@shivapoudel
Copy link
Contributor

Travis-CI is fixed after merging. Be happy...!

shivapoudel pushed a commit that referenced this pull request Sep 1, 2015
Proposed fix for ticket 66: allow extra arguments when using requirement...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants