missing https_proxy when using https pypi of other https indexes

[jsfrerot]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4
• Distribution: centos7
• Module version: 2.2.2

How to reproduce

install a python3 virtualenv without direct internet access. But use proxy to download packages from pypi

python::virtualenv { '/opt/myproject' :
        ensure     => present,
        distribute => false,
        version    => '36',
        owner      => $system_user,
        group      => 'myuser',
        cwd        => '/opt/myproject',
        proxy      => 'http://my_proxy:3128',
        virtualenv => 'virtualenv-3',
        require    => User['myuser'],
    }

What are you seeing

a timeout when installing/upgrading the pip package

What behaviour did you expect instead

a clean install

Here is the diff to fix the issue:

diff --git a/modules/python/manifests/virtualenv.pp b/modules/python/manifests/virtualenv.pp
index ad526678f..8e99e8d81 100644
--- a/modules/python/manifests/virtualenv.pp
+++ b/modules/python/manifests/virtualenv.pp
@@ -125,7 +125,7 @@ define python::virtualenv (
 
     $proxy_command = $proxy ? {
       false   => '',
-      default => "&& export http_proxy=${proxy}",
+      default => "&& export http_proxy=${proxy} https_proxy=${proxy}",
     }
 
     # Virtualenv versions prior to 1.7 do not support the