String to String[1]

voxpupuli · Oct 24, 2018 · b9b4e34 · b9b4e34
1 parent 0e5ea07
commit b9b4e34
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 36 deletions.
diff --git a/README.md b/README.md
@@ -75,6 +75,7 @@ from softwarecollections.org, set python::provider to 'rhscl' and python::versio
 of the collection you want to use (e.g., 'python27', 'python33', or 'rh-python34').
 
 ## Release Notes
+
 See [Changelog](https://github.com/voxpupuli/puppet-python/blob/master/CHANGELOG.md)
 
 ## Contributors

diff --git a/REFERENCE.md b/REFERENCE.md
@@ -256,39 +256,39 @@ Default value: 'present'
 
 ##### `filename`
 
-Data type: `Any`
+Data type: `Stdlib::Filemode`
 
 Filename.
 
 Default value: $title
 
 ##### `mode`
 
-Data type: `String`
+Data type: `String[1]`
 
 File mode.
 
 Default value: '0644'
 
 ##### `owner`
 
-Data type: `String`
+Data type: `String[1]`
 
 user owner of dotfile
 
 Default value: 'root'
 
 ##### `group`
 
-Data type: `String`
+Data type: `String[1]`
 
 group owner of dotfile
 
 Default value: 'root'
 
 ##### `config`
 
-Data type: `Any`
+Data type: `Hash`
 
 Config hash. This will be expanded to an ini-file.
 
@@ -539,15 +539,15 @@ must be unique
 
 ##### `pkgname`
 
-Data type: `String`
+Data type: `String[1]`
 
 the name of the package.
 
 Default value: $name
 
 ##### `ensure`
 
-Data type: `Variant[Enum[present, absent, latest], String]`
+Data type: `Variant[Enum[present, absent, latest], String[1]]`
 
 Require pip to be available.
 
@@ -579,15 +579,15 @@ Default value: `false`
 
 ##### `owner`
 
-Data type: `String`
+Data type: `String[1]`
 
 The owner of the virtualenv being manipulated.
 
 Default value: 'root'
 
 ##### `group`
 
-Data type: `String`
+Data type: `String[1]`
 
 The group of the virtualenv being manipulated.
 
@@ -643,23 +643,23 @@ Default value: 1800
 
 ##### `install_args`
 
-Data type: `String`
+Data type: `String[1]`
 
 Any additional installation arguments that will be supplied when running pip install.
 
 Default value: ''
 
 ##### `uninstall_args`
 
-Data type: `String`
+Data type: `String[1]`
 
 Any additional arguments that will be supplied when running pip uninstall.
 
 Default value: ''
 
 ##### `log_dir`
 
-Data type: `String`
+Data type: `String[1]`
 
 Log directory
 

diff --git a/manifests/dotfile.pp b/manifests/dotfile.pp
@@ -24,11 +24,11 @@
 #
 define python::dotfile (
   Enum['absent', 'present'] $ensure   = 'present',
-  $filename                           = $title,
-  String $owner                       = 'root',
-  String $group                       = 'root',
-  String $mode                        = '0644',
-  $config                             = {},
+  Stdlib::Filemode $filename          = $title,
+  String[1] $owner                    = 'root',
+  String[1] $group                    = 'root',
+  String[1] $mode                     = '0644',
+  Hash $config                        = {},
 ) {
   $parent_dir = dirname($filename)
 

diff --git a/manifests/pip.pp b/manifests/pip.pp
@@ -50,25 +50,25 @@
 #   }
 #
 define python::pip (
-  String $pkgname                                         = $name,
-  Variant[Enum[present, absent, latest], String] $ensure  = present,
-  String $virtualenv                                      = 'system',
-  Enum['pip', 'pip3'] $pip_provider                       = 'pip',
-  Variant[Boolean, String] $url                           = false,
-  String $owner                                           = 'root',
-  String $group                                           = 'root',
-  $umask                                                  = undef,
-  $index                                                  = false,
-  Variant[Boolean, String] $proxy                         = false,
-  $egg                                                    = false,
-  Boolean $editable                                       = false,
-  $environment                                            = [],
-  $extras                                                 = [],
-  String $install_args                                    = '',
-  String $uninstall_args                                  = '',
-  Numeric $timeout                                        = 1800,
-  String $log_dir                                         = '/tmp',
-  Array[String] $path                                     = ['/usr/local/bin','/usr/bin','/bin', '/usr/sbin'],
+  String $pkgname                                            = $name,
+  Variant[Enum[present, absent, latest], String[1]] $ensure  = present,
+  String $virtualenv                                         = 'system',
+  Enum['pip', 'pip3'] $pip_provider                          = 'pip',
+  Variant[Boolean, String] $url                              = false,
+  String[1] $owner                                           = 'root',
+  String[1] $group                                           = 'root',
+  $umask                                                     = undef,
+  $index                                                     = false,
+  Variant[Boolean, String] $proxy                            = false,
+  $egg                                                       = false,
+  Boolean $editable                                          = false,
+  $environment                                               = [],
+  $extras                                                    = [],
+  String[1] $install_args                                    = '',
+  String[1] $uninstall_args                                  = '',
+  Numeric $timeout                                           = 1800,
+  String[1] $log_dir                                         = '/tmp',
+  Array[String] $path                                        = ['/usr/local/bin','/usr/bin','/bin', '/usr/sbin'],
 ) {
   $python_provider = getparam(Class['python'], 'provider')
   $python_version  = getparam(Class['python'], 'version')