Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Add ability to use puppet collections for this install #20

Closed
wants to merge 3 commits into from
Closed

Add ability to use puppet collections for this install #20

wants to merge 3 commits into from

Conversation

kostecky
Copy link

@kostecky kostecky commented Oct 2, 2015

No description provided.

gpgkey => 'http://yum.puppetlabs.com/RPM-GPG-KEY-puppetlabs',
enabled => '1',
if $use_collections {
yumrepo { 'puppetlabs-PC1':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why call it "PC1" if the collections version is a parameter?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Bad - one sec.

@raphink
Copy link
Member

raphink commented Oct 2, 2015

That looks like a good way to fix #18. I'll look into it further on Monday I think.

@kostecky
Copy link
Author

@raphink Any chance to take a look at this?

@raphink
Copy link
Member

raphink commented Oct 27, 2015

@mcanevet can you have a look please?

@mcanevet
Copy link
Member

@kostecky what about Debian?
We definitely some acceptance tests to prevent regression and prove that it works.

@dnaeon
Copy link

dnaeon commented Nov 12, 2015

Any chance this could be fixed soon?

@raphink
Copy link
Member

raphink commented Nov 12, 2015

@dnaeon We stopped using this module recently. I will transfer the ownership to puppet-community soon most likely.

@dnaeon
Copy link

dnaeon commented Nov 12, 2015

@raphink, thanks for the feedback.

Any idea which Puppet module can be used for managing the new Puppet Server? This one looked very promising, but since you are discontinuing support for it, do you know of any other modules that could be used as a replacement of this module?

Thanks,
Marin

@raphink
Copy link
Member

raphink commented Nov 12, 2015

@dnaeon We wouldn't have made this one if we didn't have a need for it, and we have chosen to stop managing the Puppet server stack with Puppet altogether.

@dnaeon
Copy link

dnaeon commented Nov 12, 2015

@raphink thanks for the info! any chance you could share what you are using for managing the Puppet Server stack from now on?

@raphink
Copy link
Member

raphink commented Nov 12, 2015

@dnaeon We're using Docker. Our docker images are public on https://hub.docker.com/u/camptocamp. Hopefully, we'll be presenting a talk about how we compose them sometime soon (or a blog post, ping @mcanevet 😄)

@dnaeon
Copy link

dnaeon commented Nov 12, 2015

Cool, thanks and looking forward to see any blogs/presentations about it :)

@raphink
Copy link
Member

raphink commented Nov 12, 2015

@bastelfreak
Copy link
Member

bastelfreak commented Jun 5, 2016

HI @kostecky, this module recently moved to our namespace. Could you please to a rebase? Could you also add debian/ubuntu support?

@vinzent
Copy link
Contributor

vinzent commented Feb 2, 2017

IMHO the module should not provide a own class for the repo. the documentation should maybe refer to stahnma/puppetlabs_yum and ploperations/puppetlabs_apt .

If anybody wants to install puppetserver with puppet one has either already configured Puppet repos or has all the rpm's in some internal repositories.

@vinzent vinzent added the needs-feedback Further information is requested label Feb 2, 2017
@dhollinger
Copy link
Member

@vinzent I agree with that. Ultimately, this module probably shouldn't be handling the repositories for apt and yum. Those should probably be configured/managed at the profile level as a way to prevent duplicate resource declaration errors.

Example: A user wants to manage puppetdb, puppet agent, and puppetserver with Puppet and decide to declare the repository management in a profile, but that resource name conflicts with what's being set here?

Additionally, as @vinzent already pointed out, chances are that Puppet or Puppetserver has already been installed using the repos before this module ever gets applied, thus making the code a bit redundant.

@vinzent
Copy link
Contributor

vinzent commented Feb 2, 2017

closing in favor of #37

@vinzent vinzent closed this Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-feedback Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants