Manage configuration options with a hash

.fixtures.yml

@@ -1,8 +1,6 @@
 fixtures:
   repositories:
     apt: https://github.com/puppetlabs/puppetlabs-apt.git
-    augeasproviders_core: https://github.com/hercules-team/augeasproviders_core.git
-    augeasproviders_shellvar: https://github.com/hercules-team/augeasproviders_shellvar.git
     stdlib: https://github.com/puppetlabs/puppetlabs-stdlib.git
   symlinks:
     puppetserver: "#{source_dir}"

manifests/config.pp

@@ -1,18 +1,27 @@
 class puppetserver::config {
-  ::puppetserver::config::java_arg {
-    '-Xms':
-      ensure => 'present',
-      value  => $::puppetserver::java_xms,
-      ;
+  if has_key($::puppetserver::config, 'java_args') {
+    if has_key($::puppetserver::config['java_args'], 'xms') {
+      ::puppetserver::config::java_arg {
+        '-Xms':
+          ensure => 'present',
+          value  => $::puppetserver::config['java_args']['xms'],
+      }
+    }
 
-    '-Xmx':
-      ensure => 'present',
-      value  => $::puppetserver::java_xmx,
-      ;
+    if has_key($::puppetserver::config['java_args'], 'xmx') {
+      ::puppetserver::config::java_arg {
+        '-Xmx':
+          ensure => 'present',
+          value  => $::puppetserver::config['java_args']['xmx'],
+      }
+    }
 
-    '-XX:MaxPermSize=':
-      ensure => 'present',
-      value  => '256m',
-      ;
+    if has_key($::puppetserver::config['java_args'], 'maxpermsize') {
+      ::puppetserver::config::java_arg {
+        '-XX:MaxPermSize=':
+          ensure => 'present',
+          value  => $::puppetserver::config['java_args']['maxpermsize'],
+      }
+    }
   }
 }

manifests/config/java_arg.pp

@@ -5,7 +5,7 @@
   case $ensure {
     'present': {
       $changes = [
-        'set JAVA_ARGS/quote "\""',
+        'set JAVA_ARGS/quote \'"\'',
         "set JAVA_ARGS/value[.=~regexp('${name}.*')] '${name}${value}'",
       ]
     }

manifests/init.pp

@@ -3,8 +3,13 @@
   $enable  = true,
   $start   = true,
 
-  $java_xms = '2g',
-  $java_xmx = '2g',
+  $config = {
+    'java_args'     => {
+      'xms'         => '2g',
+      'xmx'         => '2g',
+      'maxpermsize' => '256m',
+    },
+  },
 ) {
   class { 'puppetserver::install': } ->
   class { 'puppetserver::config': } ~>

metadata.json

@@ -15,14 +15,6 @@
     {
       "name": "puppetlabs/stdlib",
       "version_requirement": ">=3.2.0 <5.0.0"
-    },
-    {
-      "name": "herculesteam/augeasproviders_core",
-      "version_requirement": ">=2.0.0"
-    },
-    {
-      "name": "herculesteam/augeasproviders_shellvar",
-      "version_requirement": ">=2.0.0"
     }
   ]
 }