move custom settings into settings.py.

[rmnwolf]

This addresses issue 41.

[nibalizer]

Why use so much file_line instead of a template? Puppet fully manages that file.

[rmnwolf]

I felt that using file line resources would be a little cleaner than using a template which only adds relevant variables. Do you have a strong opinion on it?

[daenney]

@nibalizer does have a point. Since we're fully managing settings.py, not just parts of it using a template would be a better way to go than file_line.

I would also write settings.py one directory up, so inside $basedir/puppetboard and not in $basedir/puppetboard/puppetboard which contains the actual source checkout (doing so also means you need to modify the wsgi.py file again).

[rmnwolf]

Okay. I'll refactor this into a template.

[rmnwolf]

Refactored and forcepushed. How's that

[nibalizer]

Just use @dev_listen_host, there is no reason to do a scope.lookupvar here. Oh i just got that you are setting variables here. There is no need to do that. Just use @variable down there in the template.

[nibalizer]

Looks good. I got confused about how you were doing the template. I get it now.

[rmnwolf]

Great! Happy to help!

MobileMail

On Jun 18, 2014, at 18:12, Spencer Krum [email protected] wrote:

Looks good. I got confused about how you were doing the template. I get it now.

—
Reply to this email directly or view it on GitHub.

This e-mail, including attachments, contains confidential and/or
proprietary information, and may be used only by the person or entity to
which it is addressed. The reader is hereby notified that any
dissemination, distribution or copying of this e-mail is prohibited. If you
have received this e-mail in error, please notify the sender by replying to
this message and delete this e-mail immediately.

[daenney]

@rmnwolf Could you remove all the scope.lookupvar things?

It should basically look like this:

<% if @dev_listen_host -%>
DEV_LISTEN_HOST = '<%= @dev_listen_host %>'
<% end -%>

There's no need to locally rebind them first. Don't forget to add the @ to the if's too.

[rmnwolf]

done. How's that look?