Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Python 3 and documentation for Python 3 on RHEL 7 #272

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Fixes for Python 3 and documentation for Python 3 on RHEL 7 #272

merged 2 commits into from
Mar 20, 2020

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Mar 20, 2020

Pull Request (PR) description

The current version of this module doesn't work with Python 3.
I was able to get it working with a small change to wsgi.py and some external packages / configurations which i've added to the README.

This Pull Request (PR) fixes the following issues

Fixes #252

@nmaludy nmaludy added the enhancement New feature or request label Mar 20, 2020
@nmaludy nmaludy requested a review from ghoneycutt March 20, 2020 12:37
}

# configure apache
class { 'apache':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be awesome to have this in an acceptance test <3

@nmaludy nmaludy changed the title [WIP] Fixes for Python 3 and documentation for Python 3 on RHEL 7 Fixes for Python 3 and documentation for Python 3 on RHEL 7 Mar 20, 2020
@nmaludy
Copy link
Member Author

nmaludy commented Mar 20, 2020

@bastelfreak it looks like the acceptance tests have been failing for a while. I'll see if I can make another PR for those next week.

@nmaludy nmaludy merged commit c0f9d32 into voxpupuli:master Mar 20, 2020
@nmaludy nmaludy deleted the bugfix/python3 branch March 20, 2020 16:29
@regner
Copy link

regner commented Mar 24, 2020

virtualenv_python doesn't appear to be valid.

Class[Puppetboard]: has no parameter named 'virtualenv_python'

@regner
Copy link

regner commented Mar 24, 2020

Looks like maybe it should be virtualenv_version: https://github.com/voxpupuli/puppet-puppetboard/blob/master/manifests/params.pp#L53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install with Python3
3 participants