rename LDAP include fragment file extension so it doesn't get include… #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 12, 2019
lukebigum
force-pushed
the
apache_ldap
branch
from
d2eacea to
0f921e7
Compare
…d into the default VHost by puppetlabs-apache's include of all *.conf files
lukebigum
force-pushed
the
apache_ldap
branch
from
0f921e7 to
e161836
Compare
|
thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #241 because I made a mess of the last PR.
When using LDAP auth on the puppetboard VHost, a file is created called puppetboard-ldap.conf. The file extension .conf is a bad choice, as this matches the inclusion glob that the puppetlabs-apache module creates:
This results in the puppetboard-ldap.conf being included in both the Puppet Board VHost and the default / top-level Apache config. If using Puppet Board on an Apache server that has other VHosts, it effectively applies the same LDAP restrictions to all other VHosts.
This patch renames the file to puppetboard-ldap.part to avoid the glob, and avoid the problem.