Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies #251

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Updating dependencies #251

merged 6 commits into from
Sep 23, 2019

Conversation

pjonesIDBS
Copy link
Contributor

Successfully tested with these versions locally. They are the current latest versions.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Successfully tested with these versions locally. They are the current latest versions.
@pjonesIDBS
Copy link
Contributor Author

There is a seperate issue with the modules venv which is blocking the build success. I won't be able to look into this until next week.

metadata.json Outdated Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
metadata.json Outdated Show resolved Hide resolved
pjonesIDBS and others added 3 commits September 17, 2019 08:33
Agreed :)

Co-Authored-By: Tim Meusel <[email protected]>
Co-Authored-By: Tim Meusel <[email protected]>
@pjonesIDBS
Copy link
Contributor Author

Sadly, this change is currently blocked by voxpupuli/pypuppetdb#158 as there's missing dependencies for the pypuppetdb module. It appears these were introduced in v1.0.0 of the pypuppetdb module.

I've confirmed that if I set pypuppetdb ==0.3.3 in requirements.txt (local equivalent to https://github.com/voxpupuli/puppetboard/blob/master/requirements.txt) then Puppet runs through correctly. Hopefully this will solve most of the build failures.

@bastelfreak, how would you prefer to move this forward? Are you okay to either add the missing requirements file to pypuppetdb and nudge the version on, or else version lock pypuppetdb in the requirements.txt for the puppetboard repo?

@bastelfreak
Copy link
Member

I think it shouldn't be too hard to fix this in pypuppetdb. We can kick of a new release afterwards.

Co-Authored-By: Tim Meusel <[email protected]>
@pjonesIDBS
Copy link
Contributor Author

@bastelfreak Tim, thanks for your help in getting the pypuppetdb updated again. It's good to see the tests all passing now :) These changes will make the puppetboard dashboard compatible with all the latest puppet forge module updates. If you're happy with these changes would we be able to release a new version of puppetboard into the forge?

Thanks,

Phil

@bastelfreak
Copy link
Member

Hi,
I will try to do a new release later. Thanks for your work.

@bastelfreak bastelfreak merged commit 8b828b6 into voxpupuli:master Sep 23, 2019
@pjonesIDBS
Copy link
Contributor Author

@bastelfreak Any news on the new release? How soon do you think something can be pushed into the forge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants