Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with pip install git requirement #11

Merged
merged 1 commit into from
Dec 17, 2013

Conversation

pavel-drabushevich
Copy link
Contributor

Your module is really great, but when I have run it in my environment (Ubuntu 12.04.3, Python 2.7.3, Pip 1.4.1, Git 1.7.9.5) it failed to install requirements. Puppetboard has one git requirement and it fail with following message:

Command /usr/bin/git clone -q git://github.com/nedap/pypuppetdb.git /var/www/puppetboard/virtenv-puppetboard/build/pypuppetdb failed with error code 128 in None

I have default config for class

    class { 'puppetboard': 
        basedir => '/var/www/puppetboard',
        require => [Package['git'], Class['python']]
    }

So I have found that add correct 'cwd' to puppetboard repository fix my problem, but I'm not python dev so I'm not sure in this fix.

@nibalizer
Copy link
Member

@pavel-drobushevich Hi! Sorry this slipped through my radar. Give me a bit to review. So Sorry!

@nibalizer
Copy link
Member

@pavel-drobushevich Looks good. Thanks!

nibalizer added a commit that referenced this pull request Dec 17, 2013
Fix problem with pip install git requirement
@nibalizer nibalizer merged commit d6a33cd into voxpupuli:master Dec 17, 2013
@pavel-drabushevich pavel-drabushevich deleted the gitRequirements branch December 17, 2013 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants